Refactor and optimize #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strager
reviewed
May 14, 2023
public/table-sort.js
Outdated
Comment on lines
95
to
108
| if (Object.values(matches).every((match) => match === null)) { | ||
| regexNotFoundCount++; | ||
| continue; | ||
| } | ||
| for (let key of Object.keys(inferableClasses)) { | ||
| if (matches[key] !== null) { | ||
| inferableClasses[key].count++; | ||
| } | ||
| if (isoDatesMatch) { | ||
| isoDatesCounter++; | ||
| if (inferableClasses[key].count >= threshold) { | ||
| th.classList.add(inferableClasses[key].class); | ||
| classNameAdded = true; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (Object.values(matches).every((match) => match === null)) { | |
| regexNotFoundCount++; | |
| continue; | |
| } | |
| for (let key of Object.keys(inferableClasses)) { | |
| if (matches[key] !== null) { | |
| inferableClasses[key].count++; | |
| } | |
| if (isoDatesMatch) { | |
| isoDatesCounter++; | |
| if (inferableClasses[key].count >= threshold) { | |
| th.classList.add(inferableClasses[key].class); | |
| classNameAdded = true; | |
| break; | |
| } | |
| } | |
| let foundMatch = false; | |
| for (let key of Object.keys(inferableClasses)) { | |
| let classRegexp = inferableClasses[key].regexp; | |
| if (tableColumn.innerText.match(classRegexp) !== null) { | |
| foundMatch = true; | |
| inferableClasses[key].count++; | |
| } | |
| if (inferableClasses[key].count >= threshold) { | |
| th.classList.add(inferableClasses[key].class); | |
| classNameAdded = true; | |
| break; | |
| } | |
| } | |
| if (!foundMatch) { | |
| regexNotFoundCount++; | |
| continue; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stragers big O video: https://www.youtube.com/watch?v=7VHG6Y2QmtM&t=1s
If 50% of the column doesn't have a regex match we break; if 50% of the column has matches and applied a class we break; .
We also removed an outer loop of the
inferSortClasses()function by moving it into the loop that makes each column sortable which is great because if theinferSortClasses()function has a critical failure the column wont become sortable (which improves performance even more)!I refactored this probably about 5 times trying different approaches sadly I didn't commit them all which could of been interesting to see the different approaches. I settled on this...
Probably a completely premature optimization; that would only effect really massive tables...